vm: fix copying PropertyDescriptor#64073
Open
legendecas wants to merge 1 commit into
Open
Conversation
nodejs-github-bot
added
c++
legendecas
changed the title
This fixes a long-standing issue that `ContextifyContext::PropertyDefinerCallback` incorrectly copies the `const PropertyDescriptor& desc`, assigning value to be `undefined` when no value present on the `PropertyDescriptor`. This is revealed after nodejs#63549 because returning `kYes` tells V8 that the definer handled it, and V8 no longer fixes it up. Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
geeksilva97
approved these changes
Jun 24, 2026
geeksilva97
added
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
geeksilva97
added
author ready
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/64073 ✔ Done loading data for nodejs/node/pull/64073 ----------------------------------- PR info ------------------------------------ Title vm: fix copying PropertyDescriptor (#64073) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch legendecas:vm-define -> nodejs:main Labels c++, vm, author ready Commits 1 - vm: fix copying PropertyDescriptor Committers 1 - Chengzhong Wu <cwu631@bloomberg.net> PR-URL: https://github.com/nodejs/node/pull/64073 Fixes: https://github.com/nodejs/node/issues/64008 Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/64073 Fixes: https://github.com/nodejs/node/issues/64008 Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 22 Jun 2026 18:54:27 GMT ✔ Approvals: 1 ✔ - Edy Silva (@geeksilva97): https://github.com/nodejs/node/pull/64073#pullrequestreview-4563572633 ✘ This PR needs to wait 97 more hours to land (or 0 minutes if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-06-25T13:19:37Z: https://ci.nodejs.org/job/node-test-pull-request/74414/ - Querying data for job/node-test-pull-request/74414/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/28189584946 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a long-standing issue that
ContextifyContext::PropertyDefinerCallbackincorrectly copies theconst PropertyDescriptor& desc, assigning value to beundefinedwhenno value present on the
PropertyDescriptor.This is revealed after #63549 because
returning
kYestells V8 that the definer handled it, and V8 no longerfixes it up.
Fixes: #64008
/cc @nodejs/vm